Add input validation to modifier methods#781
Open
JonyFang wants to merge 2 commits intoHeroTransitions:developfrom
Open
Add input validation to modifier methods#781JonyFang wants to merge 2 commits intoHeroTransitions:developfrom
JonyFang wants to merge 2 commits intoHeroTransitions:developfrom
Conversation
JonyFang
requested review from
JoeMatt,
SD10,
kuyazee and
lkzhao
as code owners
JonyFang
changed the title
- Validate position, size, scale, translate, rotate values are finite - Validate perspective is finite and non-zero - Validate duration and delay are finite, non-negative - Validate arc intensity is finite - Return empty modifier when validation fails
- Add 18 test cases for modifier input validation - Update minimum deployment target to iOS 12.0 - Add post_install hook to ensure pods compatibility - Fix libarclite error on Xcode 16+
JonyFang
force-pushed
the
feature/add-input-validation
branch
from
8a2487c to
f581d18
Compare
JonyFang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rotate, duration, delay, arc)
Why
Prevents crashes and undefined behavior caused by invalid numerical values in animations.
Test
All 18 tests pass. Invalid inputs are properly rejected without breaking existing functionality.