fix: improve onLaunchedWithItems to prevent information loss#1230
Draft
KernelDeimos wants to merge 1 commit intomainfrom
Draft
fix: improve onLaunchedWithItems to prevent information loss#1230KernelDeimos wants to merge 1 commit intomainfrom
KernelDeimos wants to merge 1 commit intomainfrom
Conversation
- Modified launch_app.js to only pass file UUID to apps\n- Updated UI.js to fetch complete file information using puter.fs.stat()\n- Ensures consistent file information and avoids URL length limitations\n\nFixes #1226 ai: true
Contributor
Author
|
Manual test failed. This doesn't work because we are neither using
pr-1230_1.5x.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ai]
Fix for issue #1226: onLaunchedWithItems implementation to prevent information loss
This PR implements the solution suggested in issue #1226 to fix the problem with
onLaunchedWithItemsbeing prone to losing information about fsentries due to property duplication.Changes:
Modified
launch_app.jsto only pass the file UUID to apps after granting the app permission to access the file:Updated
UI.jsto haveonLaunchedWithItemsfetch the file information via puter.js:puter.fs.stat()to get the complete file information using the UUIDBenefits:
Fixes #1226