Skip to content

Conversation

@botantony
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Every time I want to use this package, I see this warning message:

/opt/homebrew/bin/speedtest:960: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
  self.timestamp = '%sZ' % datetime.datetime.utcnow().isoformat()

It is a bit annoying and may cause issues when new Python versions arrive. As the last commit was 4 years ago, I think it is fair to apply this patch

Every time I want to use this package, I see this warning message:
```
/opt/homebrew/bin/speedtest:960: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
  self.timestamp = '%sZ' % datetime.datetime.utcnow().isoformat()
```

It is a bit annoying and may cause issues when new Python versions
arrive. As the last commit was 4 years ago, I think it is fair to apply
this patch

Signed-off-by: botantony <antonsm21@gmail.com>
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Aug 24, 2025
@chenrui333
Copy link
Member

sivel/speedtest-cli#808

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 24, 2025
@BrewTestBot BrewTestBot enabled auto-merge August 24, 2025 21:53
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 24, 2025
Merged via the queue into Homebrew:main with commit 6e2f725 Aug 24, 2025
19 checks passed
@botantony botantony deleted the speedtest branch August 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants