Open
Conversation
Contributor
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
afc7e54 to
f5b6de6
Compare
chenrui333
reviewed
Feb 5, 2026
| license "MPL-2.0" | ||
| head "https://github.com/quaric/zadark.git", branch: "main" | ||
|
|
||
| depends_on "node@22" => :build |
Member
There was a problem hiding this comment.
any upstream issue to track the support of node 24?
Author
There was a problem hiding this comment.
I already tried to build it, but the build failed
Member
There was a problem hiding this comment.
Have you tried reporting that to the developers?
Member
There was a problem hiding this comment.
yeah, @zeldrisho can you file a bug report in the upstream about your build failure and link here (would be good to also add as a code comment too)
chenrui333
reviewed
Feb 5, 2026
chenrui333
approved these changes
Feb 5, 2026
Member
|
some minor comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #263629
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I use github codespaces & github copilot