added German TimeOnlyToClockNotation

[SpocWeb]

Here is a checklist you should tick through before submitting a pull request:

• Implementation is clean
• Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
• No Code Analysis warnings
• There is proper unit test coverage
• If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
• There are very few or no comments (because comments shouldn't be needed if you write clean code)
• Xml documentation is added/updated for the addition/change
• Your PR is (re)based on top of the latest commits from the main branch (more info below)
• Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
• Readme is updated if you change an existing feature or add a new one
• Run either build.cmd or build.ps1 and ensure there are no test failures

[hangy]

Thanks for the suggestion! Good to see you're not using „dreiviertel zwölf“ 😜

[SpocWeb]

@hangy you can add a culture like "de-DE-BY" with "dreiviertel zwölf" if you like 😜

[hangy]

I think the German changes are fine, but I don't know about changes to the public API.

[hangy]

Someone that knows the API policies of the project better than me should decide whether this change is appropriate, considering the existing public API.

[SimonCropp]

does it need to be public? if so can you add some docs that explain the use cases

[hazzik]

I would suggest to make it internal for now.

[SimonCropp]

@SpocWeb can you rebase

[SpocWeb]

@SimonCropp sure, will try and also add some explanation to the contended Method(s) over the weekend, thanks for considering this.

[SpocWeb]

Hi, I don't know why the CI Builds fail. I am not allowed to look at the errors and locally it builds for me in all Configurations.
Please share the Build Error Details with me.