Optimize FromUnderscoreDashSeparatedWords to reduce allocations#1660
Open
alexzzzs wants to merge 3 commits intoHumanizr:mainfrom
Open
Optimize FromUnderscoreDashSeparatedWords to reduce allocations#1660alexzzzs wants to merge 3 commits intoHumanizr:mainfrom
alexzzzs wants to merge 3 commits intoHumanizr:mainfrom
Conversation
Collaborator
Author
|
I wrote the manual loop to handle both _ and - in a single pass to avoid iterating over the span twice. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the FromUnderscoreDashSeparatedWords method to reduce memory allocations during string humanization. The optimization is particularly beneficial when processing strings with underscores or dashes.
Key changes:
- Replaced
string.Join(" ", input.Split(['_', '-']))with more efficient implementations - Added
string.Createfor .NET 7.0+ to enable zero-allocation in-place character replacement - Used chained
Replacecalls as a fallback for older frameworks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize FromUnderscoreDashSeparatedWords to reduce allocations
Optimizes the
FromUnderscoreDashSeparatedWordsmethod to eliminate unnecessary memory allocations.The original implementation (string.Join(" ", input.Split(['_', '-']))) allocates multiple intermediate strings and arrays for each call.
Changes
string.Join(" ", input.Split(['_', '-']))withstring.Createfor .NET 7.0+ (in-place modification)Replacefallback for older frameworksTesting