Fix/rofi kill command

[naye2m]

Pull Request

Description

Please read these instructions and remove unnecessary text.

• Try to include a summary of the changes and which issue is fixed.
• Also include relevant motivation and context (if applicable).
• Make sure to make PR against dev and not the master
• List any dependencies that are required for this change. (e.g., packages or other PRs)
• Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
• Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update (non-breaking change; modified files are limited to the documentations)
• Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
• Other (provide details below)

Checklist

Please put an x in the boxes that apply:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My commit message follows the commit guidelines.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added a changelog entry.
• I have added necessary comments/documentation to my code.
• I have added tests to cover my changes.
• I have tested my code locally and it works as expected. ( partially )
• All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

The new major version of rofi no longer works with 'pkill rofi'. that creates a bug
This PR updates all code to use 'killall rofi' to ensure compatibility.

• Replaces all 'pkill rofi' commands with 'killall rofi'
• Tested with rofi v2 on Linux

Summary by CodeRabbit

• Refactor

  • Standardized keybinding behavior and normalized syntax across configs to improve launcher and theme/ wallpaper interactions.

• Bug Fixes

  • Improved reliability of launcher invocations and gesture-triggered actions.

• Chores

  • Updated CONTRIBUTORS list with a new collaborator entry.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new collaborator entry to CONTRIBUTORS.md and replaces various pkill invocations with killall for terminating rofi across multiple configs and helper scripts.

Changes

Cohort / File(s)	Summary
Contributors CONTRIBUTORS.md	Added new collaborator entry (naye2m).
Shell helper scripts Configs/.local/lib/hyde/cliphist.sh, Configs/.local/lib/hyde/emoji-picker.sh, Configs/.local/lib/hyde/glyph-picker.sh, Configs/.local/lib/hyde/keybinds_hint.sh, Configs/.local/lib/hyde/rofilaunch.sh, Configs/.local/lib/hyde/wallbashtoggle.sh	Replaced pkill variants with killall (often killall -u "$USER" rofi or killall rofi) for rofi termination; logic otherwise unchanged.
Hypr / gesture configs Configs/.config/hypr/keybindings.conf, Configs/.config/libinput-gestures.conf, Configs/.local/share/hyde/keybindings.conf, Configs/.local/share/hyde/templates/hypr/keybindings.conf	Replaced pkill -x rofi (or other pkill uses) with killall rofi in multiple keybindings/launcher lines; binds and commands preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

• kRHYME7

Poem

🐰 New name nibbled into the list so neat,
I hopped through configs — a tidy little feat.
From pkill to killall the rofi calls fall,
A tiny change, but I celebrated it all! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix/rofi kill command' directly describes the main change: replacing pkill with killall for rofi process termination across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[naye2m]

Who should I add as a reviewer for this PR?

[Copilot]

Pull request overview

This pull request addresses a compatibility issue with rofi v2, which no longer works correctly with the pkill rofi command. The PR updates all instances of pkill rofi to killall rofi across configuration files and shell scripts to ensure proper functionality with the newer rofi version.

Changes:

• Replaced pkill rofi with killall rofi in keybindings configuration files
• Updated shell scripts that toggle rofi menus to use killall instead of pkill
• Added contributor to CONTRIBUTORS.md

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
Configs/.local/share/hyde/templates/hypr/keybindings.conf	Updated keybindings to use killall -x rofi instead of pkill -x rofi
Configs/.local/share/hyde/keybindings.conf	Updated keybindings to use killall -x rofi instead of pkill -x rofi
Configs/.local/lib/hyde/wallbashtoggle.sh	Changed rofi kill command from pkill -u "$USER" rofi to killall -u "$USER" rofi
Configs/.local/lib/hyde/rofilaunch.sh	Changed rofi kill command from pkill rofi to killall rofi (with extra space)
Configs/.local/lib/hyde/keybinds_hint.sh	Changed rofi kill command from pkill -x rofi to killall -x rofi
Configs/.local/lib/hyde/glyph-picker.sh	Changed rofi kill command from pkill -u "$USER" rofi to killall -u "$USER" rofi
Configs/.local/lib/hyde/emoji-picker.sh	Changed rofi kill command from pkill -u "$USER" rofi to killall -u "$USER" rofi
Configs/.local/lib/hyde/cliphist.sh	Changed rofi kill command from pkill -u "$USER" rofi to killall -u "$USER" rofi
Configs/.config/libinput-gestures.conf	Changed rofi kill command from pkill rofi to killall rofi (with extra space)
Configs/.config/hypr/keybindings.conf	Updated keybindings to use killall -x rofi instead of pkill -x rofi
CONTRIBUTORS.md	Added @naye2m to the contributors list

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Configs/.local/lib/hyde/emoji-picker.sh`:
- Line 2: The script currently calls killall -u "$USER" rofi directly which
fails if psmisc isn't installed; update emoji-picker.sh to check for killall
availability (command -v killall) and use it if present, otherwise fall back to
pkill (command -v pkill) to terminate the rofi process (use the same -u "$USER"
semantics or equivalent pkill -u "$USER" -x rofi), and if neither exists, exit
with a safe no-op or an informative error; ensure the replacement preserves the
original behavior of exiting after a successful kill.