PROCESS : 'compare_licences' may be tested with cypress-cucumber (see…#323
PROCESS : 'compare_licences' may be tested with cypress-cucumber (see…#323floporsch911 wants to merge 1 commit intomainfrom
Conversation
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution @floporsch911.
Please consider the following improvements so that your contribution can be integrated.
Regards.
|
|
||
| Soit "Víly (Charles Perrault)" le document principal | ||
| Et "CC-BY-NC-ND" le code de la licence du document principal | ||
| Et "CC-BY-NC-ND" le nom de la licence du document principal |
There was a problem hiding this comment.
This change is not coherent with line 18 of the same file.
Either change both or keep both.
| 'Restaurer la vapeur': '/6b56ee657c870dfacd34e9ae4e050fcc', | ||
| 'Vestiges (diagramme de classes)': '/146e6e8442f0405b721b79357d0021e3', | ||
| 'Víly (Charles Perrault)' : '/420ab198674f11eda3b7a3fdd5ea984f', | ||
| 'Entretien avec un responsable d\'opération' : '/05b61f5285c711ed97bf6b9b56808c45', |
There was a problem hiding this comment.
Previous lines (39) is related to your scenario but not this one.
| expect(uris).to.contain.key(title); | ||
| cy.get(`a.icon.open[href*="#${uris[title].slice(1)}"]`).click(); | ||
| } | ||
| ); |
There was a problem hiding this comment.
I think there is a misunderstanding about what this step is intended to do. If you look at the existing in Capybara (see
https://github.com/Hypertopic/HyperGlosae/blob/main/features/step_definitions/event.rb#L1-L3), it only clicks the open button, in order to see this document content side by side with the focused one.
This step is a prerequisite to check that both licences are compatible.
| throw new Error('Neither img nor span found in .license, or license text does not contain expected value'); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
The existing Capybara code was perhaps too simple but why is this code so complicated?
Please have a look at cy.contains() documentation. You can do a lot, with just one call.
2 participants
… #199).
We, Florian Chaffard, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.