Renaming Production|Steel in legacy projects to Production|Iron and Steel|Steel#348
Closed
PhilippVerpoort wants to merge 1 commit intoIAMconsortium:mainfrom
Closed
Conversation
* Creates file `variable-cleanup.yml` in `legacy` subdirectory. * Adds mapping of `Production|Steel` to `Production|Iron and Steel|Steel` as a first example.
PhilippVerpoort
changed the title
Production|Steel in legacy project(s) to Production|Iron and Steel|SteelProduction|Steel in legacy projects to Production|Iron and Steel|Steel
Member
|
Thanks @PhilippVerpoort, this is ok. Should I merge or do you want to add more items to this PR? |
Author
|
Please merge this one. I will create additional PRs for my other items. |
danielhuppmann
requested changes
Dec 1, 2025
Member
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
The provided mapping is not correct, see below.
| dimension: variable | ||
| rename: | ||
| # Variable `Production|Steel` isn't correctly mapped to `Production|Iron and Steel|Steel` in SHAPE. | ||
| - "Production|Steel": "Production|Iron and Steel|Steel" |
Member
There was a problem hiding this comment.
I had a closer look at the SHAPE database and it seems that they actually used two different variables for steel production: "Production|Steel" is reported only by IMAGE, but "Production|Iron and Steel|Volume" is reported by IMAGE (duplicate reporting) and the other models.
Suggested change
| - "Production|Steel": "Production|Iron and Steel|Steel" | |
| - "Production|Iron and Steel|Volume": "Production|Iron and Steel|Steel" |
Member
|
Closing in favor of #369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
Production|Steelfrom SHAPE is not mapped toProduction|Iron and Steel|Steel. This is a problem in projects relying on common-definitions that try to import scenarios from legacy projects.It should be possible to resolve this by adding a
variable-cleanup.ymlin thelegacysubdirectory, as suggested by this PR.This PR is based on discussions in #338.