Open
Conversation
Member
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
Thanks, here's a quick first review.
| range: [ 0, 100 ] | ||
| sdg: 7 | ||
| skip-region-aggregation: true | ||
| shape: Expenditure Share|Residential Energy |
Member
There was a problem hiding this comment.
This doesn't seem right, how can SHAPE have used one variable for all variations by Population Decile?
Contributor
Author
There was a problem hiding this comment.
Apologies, this line should have been removed. It was erroneously included when defining the variable in the YAML based on already existing entries
| notes: The Potential Species Loss (PSL) indicator represents the number of species that could become committed to | ||
| global extinction, estimated for each ecoregions and taxonomic levels (mammals, birds, amphibians, reptiles, and plants). | ||
| It combines theoriginal species count in the ecoregion and the reduction in natural habitat,the threat level for each | ||
| ecoregion and taxon, the taxon endemism, and thespecies' preference for new artificial habitat induced by land use changes. No newline at end of file |
Member
There was a problem hiding this comment.
Please format to a maximum line width of 88 characters and add an empty line at the end of the file
| - Terrestrial Biodiversity|Potential Species Loss: | ||
| description: Number of plant and vertebrate species committed to extinction due to habitat loss | ||
| unit: number of species | ||
| min: 0 |
Member
There was a problem hiding this comment.
We streamlined the convention on bounds with the pyam.IamDataFrame.validate() method.
Suggested change
| min: 0 | |
| lower_bound: 0 |
This also needs to be adjusted in the ""Shannon Crop Diversity Index" variable.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds several new variables recently included in the SUSMIP project
@danielhuppmann