Chart value bindPVThroughClaimRef to control how PV / PVC pairs are bound#149
Open
unlightable wants to merge 1 commit intoIBM:mainfrom
Open
Chart value bindPVThroughClaimRef to control how PV / PVC pairs are bound#149unlightable wants to merge 1 commit intoIBM:mainfrom
bindPVThroughClaimRef to control how PV / PVC pairs are bound#149unlightable wants to merge 1 commit intoIBM:mainfrom
Conversation
… bound. `true` uses partially pre-filled spec.claimRef in PV `false` fills spec.volumeName of PVC instead Signed-off-by: unlightable <unlightable@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-binding PVC to PV through
claimRefworks fine on creation.But it seems like editing PV manifest afterwards will break things (especially in case of removing
spec.claimRef.uid).E. g. on my kubernetes provider it unbinds PVC and errors it out due to multiple bindings to same PV.
This becomes an issue if the chart is under some gitops solution (like Argo CD) that will continuously apply manifests from chart re-renders.
Fortunately, everything works fine when using
volumeNamereference in PVC.Although this way PV could be bound to something else in case of
storageClasscollision, it doesn't seem like a big issue to me.