Draft
Conversation
* Fix race condition with parallel HDF5 calls Add some locks, in particular for H5Location::nameExists. Also remove some unnecessary H5File::getId calls. * Safely close HDF5 files * Check pthread_create retval * cleanup
git subrepo clone --branch=develop --force git@github.com:AMICI-dev/AMICI.git deps/AMICI subrepo: subdir: "deps/AMICI" merged: "8ef53c88" upstream: origin: "git@github.com:AMICI-dev/AMICI.git" branch: "develop" commit: "8ef53c88" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
# Conflicts: # deps/AMICI/.gitrepo # deps/AMICI/python/amici/__init__.py
|
SonarCloud Quality Gate failed. |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
SonarCloud Quality Gate failed. |
dweindl
force-pushed
the
develop
branch
2 times, most recently
from
bbf24f8 to
e4fb08a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #349