Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1606 +/- ##
===========================================
- Coverage 83.61% 83.57% -0.04%
===========================================
Files 163 163
Lines 14018 14018
===========================================
- Hits 11721 11716 -5
- Misses 2297 2302 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
reviewed
Sep 24, 2025
| "metadata": {}, | ||
| "cell_type": "markdown", | ||
| "source": "The AMICI model can be used to directly simulate the model and customize outputs such as states, sensitivities, and observables. For more details, see the `amici notebook`. We want to integrate this simulation model into an objective function we can repeatedly call during optimization." | ||
| }, |
Member
There was a problem hiding this comment.
I don't find this reference particularly helpful here. That other notebook is mostly irrelevant to PEtab users. I'd rather remove the whole Import model to AMICI section here, unless it's extended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connected to discussion in #1562