Skip to content

MNT: Add optional odNNN in SPICE ephemeris file names #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greglucas merged 1 commit into from
Oct 15, 2025
Merged

MNT: Add optional odNNN in SPICE ephemeris file names #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions imap_data_access/file_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,7 @@ class SPICEFilePath(ImapFilePath):
spacecraft_ephemeris_file_pattern = (
r"(imap)_"
r"(?P<type>[a-zA-Z0-9\-]+)_"
r"(?:od\d{3}_)?" # Optionally match and ignore odNNN
r"(?P<start_date>[\d]{8})_"
r"(?P<end_date>[\d]{8})"
r"(?:|_v(?P<version>[\d]*))\."
Expand Down
14 changes: 14 additions & 0 deletions tests/test_file_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,20 @@ def test_spice_file_path():
] / Path("imap/spice/spk/L1_de431.bsp")
assert lagrange_point_file.spice_metadata["type"] == "lagrange_point"

# Ephemeris with "od" in the filename
ephem_file = SPICEFilePath("imap_pred_od004_20251002_20251113_v01.bsp")
assert ephem_file.construct_path() == imap_data_access.config["DATA_DIR"] / Path(
"imap/spice/spk/imap_pred_od004_20251002_20251113_v01.bsp"
)
assert ephem_file.spice_metadata["type"] == "ephemeris_predicted"

# Ephemeris without "od" in the filename
ephem_file = SPICEFilePath("imap_pred_20251002_20251113_v01.bsp")
assert ephem_file.construct_path() == imap_data_access.config["DATA_DIR"] / Path(
"imap/spice/spk/imap_pred_20251002_20251113_v01.bsp"
)
assert ephem_file.spice_metadata["type"] == "ephemeris_predicted"


def test_spice_extract_dps_pointing_parts():
"""Test the new DPS pointing kernel filename parsing."""
Expand Down