test: Fixed nondeterministic failure in createTests()#6493
Open
yonghanlin wants to merge 2 commits intoINRIA:masterfrom
Open
test: Fixed nondeterministic failure in createTests()#6493yonghanlin wants to merge 2 commits intoINRIA:masterfrom
yonghanlin wants to merge 2 commits intoINRIA:masterfrom
Conversation
…eParametrizedTest
yonghanlin
changed the title
yonghanlin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a nondeterministic test failure in
ReplaceParametrizedTest.createTests()within.module when running with NonDex.Problem
The nondeterminism occurs because the test generates candidate
CtElementinstances from collections whose iteration order is not guaranteed. Depending on the iteration order, the test may produce element types that are incompatible with the role being tested:IMPORT_REFERENCE, aCtLocalVariableReferencecould be selected, which is not an importable reference.PATTERN, aCtUnnamedPatterncould be selected, which is only valid inside record patterns.Reproduce Test
To reproduce the failure, run NonDex on
.module using the following commands:The Fix
IMPORT_REFERENCE,itemTypeis set toCtTypeReference.class, ensuring the created element is always an importable reference.PATTERN, if the generated argument is an instance ofCtUnnamedPattern, it is replaced by a validCtTypePatternwith its type set toObject.