Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR updates the archiving commands so that, when triggered via the engine (execute method), they now create the OAI_ORE and DataCite xml files in a transaction (since the code needs to read the db), drop out of any transaction to do the potentially long process of creating the zipped bag, and then update the archival status on the datasetversion in a new transaction at the end.
It also includes a couple minor improvements:
Which issue(s) this PR closes:
Special notes for your reviewer:
FWIW: This is one of several PRs related to updates being done to improve archiving scalability at QDR and DANS. Some are relatively minor cleanup while others are more significant. I'm submitting them all to avoid drift in QDR's fork and to leverage QDR testing (where all of these are being tested together).
This builds on #12103
The changes for this specific PR are the ones on Jan 28 and the first one there has the basic overall change: The abstract command execute method now computes the ORE and DataCite XML values and passes them to the no transaction performArchivingAndPersist method which them calls the particular child class's refactored performArchiveSubmission method before finally calling persistResult in a new transaction to write the status to the datasetversion.
Suggestions on how to test this: Primarily regression testing to assure archiving still works. I don't know how easy it would be to see lower memory use or other impact of not having a long-running transaction or of that is worth the effort.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: