Fixed problems with the autoionisation rates#40
Open
hshongjie wants to merge 1 commit intoITA-Solar:masterfrom
Open
Fixed problems with the autoionisation rates#40hshongjie wants to merge 1 commit intoITA-Solar:masterfrom
hshongjie wants to merge 1 commit intoITA-Solar:masterfrom
Conversation
Fixed the values of Ca and Fe auto-ionization cases.
Member
|
Thank you for the contribution! I don't have time right now to test if this is correct, but perhaps you could also add this PR to Han's version? Maybe he can review it first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoionisation rates for Ca and Fe were not calculated properly because of two missing lines in each if-block. Also corrected the cross-section values (a-values) according to AR85.