Draft
Conversation
b419007 to
730543b
Compare
oxzi
reviewed
Jan 9, 2026
Member
oxzi
left a comment
There was a problem hiding this comment.
This draft PR is quite old and a bit outdated. Do you want to proceed here, @lippserd?
In general, I am in favor of such a testing script and I guess everyone of us has its own kind, which is not so ideal.
For example, I have an uncommited tests/test.sh like the following.
Click here!!1
#!/bin/sh
set -eu
cd ..
CGO_ENABLED=0 go build ./cmd/icingadb
pushd tests
go test -o ../icingadb-test -c .
pushd sql
go test -o ../../icingadb-test-sql -c .
popd
popd
set +e -x
for t in mysql pgsql; do
#for t in pgsql; do
export ICINGADB_TESTS_DATABASE_TYPE="$t"
export ICINGA_TESTING_ICINGADB_BINARY="$(pwd)/icingadb"
export ICINGA_TESTING_ICINGADB_SCHEMA_MYSQL="$(pwd)/schema/mysql/schema.sql"
export ICINGA_TESTING_ICINGADB_SCHEMA_PGSQL="$(pwd)/schema/pgsql/schema.sql"
./icingadb-test -icingatesting.debuglog debug.log -test.v # -test.run TestCleanupAndRetention
#./icingadb-test -icingatesting.debuglog debug.log -test.v -test.run TestCleanupAndRetention
# ./icingadb-test-sql -icingatesting.debuglog debug-sql.log -test.v
# ./icingadb-test -icingatesting.debuglog debug.log -test.v # -test.run '^\QTestSla\E$/^\QMultipleStateChangesDecimals'
doneShould we continue here or would you consider closing this PR? With the new year, I am trying to clean up the issue tracker a bit.
|
|
||
| run() { | ||
| export ICINGA_TESTING_ICINGADB_BINARY=icingadb | ||
| export ICINGA_TESTING_ICINGADB_SCHEMA=../schema/mysql/schema.sql |
Member
There was a problem hiding this comment.
There are ICINGA_TESTING_ICINGADB_SCHEMA_MYSQL and ICINGA_TESTING_ICINGADB_SCHEMA_PGSQL now.
Member
Author
You're very welcome to take over or introduce something new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.