Skip to content

Introduce AuthenticationHook#onAuthFromSession()#5467

Merged
lippserd merged 1 commit intomainfrom
onAuthFromSession
Jan 28, 2026
Merged

Introduce AuthenticationHook#onAuthFromSession()#5467
lippserd merged 1 commit intomainfrom
onAuthFromSession

Conversation

@Al2Klimov
Copy link
Member

Especially useful for code not suitable for ApplicationStateHook due to the fact that a user can block requests to /application-state.

This PR also questions the existence of #5433.

Especially useful for code not suitable for ApplicationStateHook due to the fact that a user can block requests to /application-state.

This comment was marked as resolved.

@lippserd
Copy link
Member

This PR also questions the existence of #5433.

Why?

@lippserd
Copy link
Member

This Copilot review is just spam. It would be great if you could hide the comment.

@Al2Klimov
Copy link
Member Author

Why?

Here, I've added yet another hook which is called on every single non-login request of authenticated users.

This Copilot review is just spam.

Just here or also in my other recent PRs?

It would be great if you could hide the comment.

Done.

@lippserd
Copy link
Member

Why?

Here, I've added yet another hook which is called on every single non-login request of authenticated users.

But only for requests that require authentication, right? Anyway, the request hook serves a completely different purpose.

Just here or also in my other recent PRs?

It would be great if you could hide the comment.

Done.

Just here, thx!

@lippserd lippserd self-requested a review January 28, 2026 08:53
@lippserd lippserd merged commit a73cd1c into main Jan 28, 2026
19 checks passed
@lippserd lippserd deleted the onAuthFromSession branch January 28, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants