Skip to content

fix(textarea): remove space if prefix/suffix is hidden #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simeonoff merged 5 commits into from
Jan 7, 2025
Merged

fix(textarea): remove space if prefix/suffix is hidden #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77426e2
fix(textarea): remove space if prefix/suffix is hidden
SisIvanova Dec 20, 2024
6f1bbec
Merge branch 'master' into sivanova/fix-1508
simeonoff Jan 6, 2025
48c994a
fix(textarea/input): remove prefix/suffix part if hidden
SisIvanova Jan 7, 2025
72e28be
Merge branch 'master' into sivanova/fix-1508
simeonoff Jan 7, 2025
cc81b70
Merge branch 'master' into sivanova/fix-1508
simeonoff Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/input/input-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,16 @@ export abstract class IgcInputBaseComponent extends FormAssociatedRequiredMixin(
@queryAssignedElements({ slot: 'helper-text' })
protected _helperText!: Array<HTMLElement>;

@queryAssignedElements({ slot: 'prefix' })
@queryAssignedElements({
slot: 'prefix',
selector: '[slot="prefix"]:not([hidden])',
})
protected prefixes!: Array<HTMLElement>;

@queryAssignedElements({ slot: 'suffix' })
@queryAssignedElements({
slot: 'suffix',
selector: '[slot="suffix"]:not([hidden])',
})
protected suffixes!: Array<HTMLElement>;

protected get _isMaterial() {
Expand Down
10 changes: 8 additions & 2 deletions src/components/textarea/textarea.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,16 @@ export default class IgcTextareaComponent extends FormAssociatedRequiredMixin(
@queryAssignedNodes({ flatten: true })
private projected!: Array<Node>;

@queryAssignedElements({ slot: 'prefix' })
@queryAssignedElements({
slot: 'prefix',
selector: '[slot="prefix"]:not([hidden])',
})
protected prefixes!: Array<HTMLElement>;

@queryAssignedElements({ slot: 'suffix' })
@queryAssignedElements({
slot: 'suffix',
selector: '[slot="suffix"]:not([hidden])',
})
protected suffixes!: Array<HTMLElement>;

@query('textarea', true)
Expand Down
Loading