fix(icon-broadcast): Do not sync between wc services, just with angul…#1532
Merged
rkaraivanov merged 4 commits intomasterfrom Jan 8, 2025
Merged
fix(icon-broadcast): Do not sync between wc services, just with angul…#1532rkaraivanov merged 4 commits intomasterfrom
rkaraivanov merged 4 commits intomasterfrom
Conversation
damyanpetev
previously approved these changes
Jan 7, 2025
rkaraivanov
requested changes
Jan 7, 2025
Member
rkaraivanov
left a comment
rkaraivanov
left a comment
There was a problem hiding this comment.
LGTM
I was wondering if you can reproduce the bug and cover it in our test suite by creating (several) services that mimic the Angular icon service logic and try to trample over the icon service in the library? If possible, this can be a separate PR.
rkaraivanov
previously approved these changes
Jan 8, 2025
damyanpetev
reviewed
Jan 8, 2025
damyanpetev
reviewed
Jan 8, 2025
damyanpetev
approved these changes
Jan 8, 2025
rkaraivanov
approved these changes
Jan 8, 2025
dkamburov
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ar-elements.
Closes #1524