Skip to content

Add editable date range input #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ddaribo wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Add editable date range input #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
18aef58
poc editable date range input
ddaribo Apr 17, 2025
ee9d1fc
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Jun 10, 2025
8870280
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Jun 17, 2025
773dc52
feat(drp): handle the alt + arrow down/up focus properly for single i…
ddaribo Jun 17, 2025
73f897e
Merge branch 'master' into bpachilova/range-editable-date-input
rkaraivanov Jun 23, 2025
cb12b8a
Merge branch 'master' into bpachilova/range-editable-date-input
rkaraivanov Jun 27, 2025
5ee269f
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Jul 15, 2025
cb41172
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Jul 28, 2025
2b29c4a
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Jul 28, 2025
7ca2d82
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Aug 15, 2025
3a366f7
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Oct 28, 2025
c8c3a68
Merge branch 'master' into bpachilova/range-editable-date-input & get…
ddaribo Feb 20, 2026
adf7e14
Merge branch 'master' into bpachilova/range-editable-date-input
ddaribo Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
494 changes: 494 additions & 0 deletions src/components/date-range-picker/date-range-input.ts
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 22 additions & 19 deletions src/components/date-range-picker/date-range-picker-single.form.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import {
type ValidationContainerTestsParams,
ValidityHelpers,
} from '../common/validity-helpers.spec.js';
import IgcInputComponent from '../input/input.js';
import type IgcDateRangeInputComponentComponent from './date-range-input.js';
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type name has a duplicate "Component" suffix. Should be IgcDateRangeInputComponent instead of IgcDateRangeInputComponentComponent.

Copilot uses AI. Check for mistakes.
import IgcDateRangeInputComponent from './date-range-input.js';
import IgcDateRangePickerComponent, {
type DateRangeValue,
} from './date-range-picker.js';
Expand All @@ -21,7 +22,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
before(() => defineComponents(IgcDateRangePickerComponent));

let picker: IgcDateRangePickerComponent;
let input: IgcInputComponent;
let input: IgcDateRangeInputComponentComponent;
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable uses the incorrect type with duplicate "Component" suffix. Should be declared as IgcDateRangeInputComponent to match the corrected import.

Copilot uses AI. Check for mistakes.
let startKey = '';
let endKey = '';

Expand Down Expand Up @@ -67,24 +68,26 @@ describe('Date Range Picker Single Input - Form integration', () => {
await elementUpdated(spec.element);

input = picker.renderRoot.querySelector(
IgcInputComponent.tagName
) as IgcInputComponent;
IgcDateRangeInputComponent.tagName
) as IgcDateRangeInputComponent;

checkSelectedRange(spec.element, value, false);

spec.reset();
await elementUpdated(spec.element);

expect(spec.element.value).to.deep.equal(initial);
expect(input.value).to.equal('');
expect(input.value).to.deep.equal({ start: null, end: null });
});

it('should not be in invalid state on reset for a required control which previously had value', () => {
spec.setProperties({ value: value });
spec.setProperties({ required: true });

spec.assertSubmitPasses();
const input = picker.renderRoot.querySelector(IgcInputComponent.tagName)!;
const input = picker.renderRoot.querySelector(
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.false;

spec.setProperties({ value: null });
Expand All @@ -100,7 +103,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitFails();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.true;

Expand All @@ -118,10 +121,10 @@ describe('Date Range Picker Single Input - Form integration', () => {
await elementUpdated(spec.element);

input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
) as IgcInputComponent;
IgcDateRangeInputComponent.tagName
) as IgcDateRangeInputComponent;

expect(input.value).to.equal('');
expect(input.value).to.deep.equal({ start: null, end: null });

spec.reset();
await elementUpdated(spec.element);
Expand All @@ -146,7 +149,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitFails();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.true;

Expand All @@ -162,7 +165,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitPasses();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.false;

Expand Down Expand Up @@ -205,7 +208,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitPasses();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.false;

Expand Down Expand Up @@ -246,7 +249,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitPasses();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.false;

Expand Down Expand Up @@ -279,7 +282,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitPasses();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.false;

Expand Down Expand Up @@ -323,7 +326,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitFails();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.true;

Expand Down Expand Up @@ -383,7 +386,7 @@ describe('Date Range Picker Single Input - Form integration', () => {
spec.assertSubmitFails();
await elementUpdated(spec.element);
const input = spec.element.renderRoot.querySelector(
IgcInputComponent.tagName
IgcDateRangeInputComponent.tagName
)!;
expect(input.invalid).to.be.true;

Expand Down Expand Up @@ -416,8 +419,8 @@ describe('Date Range Picker Single Input - Form integration', () => {
html`<igc-date-range-picker required></igc-date-range-picker>`
);
const input = picker.renderRoot.querySelector(
IgcInputComponent.tagName
) as IgcInputComponent;
IgcDateRangeInputComponent.tagName
) as IgcDateRangeInputComponent;

expect(picker.invalid).to.be.false;
expect(input.invalid).to.be.false;
Expand Down
Loading
Loading