fix(list): theme variables replicated for all list components#1853
Merged
rkaraivanov merged 1 commit intomasterfrom Sep 17, 2025
Merged
fix(list): theme variables replicated for all list components#1853rkaraivanov merged 1 commit intomasterfrom
rkaraivanov merged 1 commit intomasterfrom
Conversation
This PR fixes a critical issue with the list component that prevents it from being styled using CSS variables alone. The component includes the CSS variables for the list theme in all list-related components (list-item, list-header, and the list host itself), forcing people to have to override the variables in all three instances. This PR includes the theme CSS variables only in the list host, while component specific overrides for the item and header are preserved and carried by each component separately.
SisIvanova
approved these changes
Sep 17, 2025
rkaraivanov
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue with the list component that prevents it from being styled using CSS variables alone.
The component includes the CSS variables for the list theme in all list-related components (list-item, list-header, and the list host itself), forcing people to have to override the variables in all three instances.
This PR includes the theme CSS variables only in the list host, while component specific overrides for the item and header are preserved and carried by each component separately.