Skip to content

fix(calendar): aria-hidden for days in perfect month#2079

Merged
rkaraivanov merged 2 commits intomasterfrom
rkaraivanov/fix-aria-with-perfect-month
Feb 2, 2026
Merged

fix(calendar): aria-hidden for days in perfect month#2079
rkaraivanov merged 2 commits intomasterfrom
rkaraivanov/fix-aria-with-perfect-month

Conversation

@rkaraivanov
Copy link
Member

When the month is perfect, apply the aria-hidden attribute based on whether all days in the week are hidden, not just the edge weeks.

When the month is [perfect](https://en.wikipedia.org/wiki/Perfect_month), apply
the `aria-hidden` attribute based on whether all days in the week are hidden, not
just the edge weeks.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the aria-hidden attribute logic for calendar weeks in a "perfect month" (a month where all weeks are fully contained within that month). Previously, the attribute was only applied to edge weeks (first and last). Now it applies to any week where all days are hidden.

Changes:

  • Removed the edge week restriction for determining when to apply aria-hidden
  • Simplified the hidden state check to apply uniformly across all weeks

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rkaraivanov rkaraivanov requested a review from Copilot February 2, 2026 11:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@rkaraivanov rkaraivanov merged commit 7046a66 into master Feb 2, 2026
7 checks passed
@rkaraivanov rkaraivanov deleted the rkaraivanov/fix-aria-with-perfect-month branch February 2, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants