refactor(badge): Improved badge component and tests#2089
Merged
rkaraivanov merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the badge component documentation and slot/icon handling, and expands unit test coverage around icon slotting.
Changes:
- Clarified Storybook argTypes and inline docs for
variantanddot. - Updated
igc-badgeJSDoc with more explicit API docs and examples, plusiconcsspart documentation. - Simplified icon detection logic and added a unit test for the
iconpart when anigc-iconis slotted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| stories/badge.stories.ts | Improves Storybook control/docs wording for variant and dot. |
| src/components/badge/badge.ts | Updates component JSDoc and refactors icon detection used for part="icon". |
| src/components/badge/badge.spec.ts | Registers igc-icon for tests and adds coverage for part~="icon". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved badge component and tests
Type of Change
Checklist