fix(icon): use plain Map in BroadcastChannel messages to fix Safari DataCloneError#2127
Closed
desig9stein wants to merge 2 commits intomasterfrom
Closed
fix(icon): use plain Map in BroadcastChannel messages to fix Safari DataCloneError#2127desig9stein wants to merge 2 commits intomasterfrom
desig9stein wants to merge 2 commits intomasterfrom
Conversation
…ataCloneError DefaultMap instances contain a non-cloneable _factoryFn function property. When passed to BroadcastChannel.postMessage(), Safari throws DataCloneError since functions are not structured-cloneable (Chrome silently tolerates it). Replace DefaultMap with plain Map objects in all broadcast payloads: - _getUserRefsCollection and _getUserSetCollection in icon-state.broadcast.ts - register and setIconRef broadcast calls in icon.registry.ts
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Safari DataCloneError when syncing icon registry state across contexts by ensuring BroadcastChannel messages only contain structured-cloneable data.
Changes:
- Replaced
DefaultMapwith plainMapinstances in icon registration and icon reference update broadcast payloads. - Updated
IconsStateBroadcastsync-state payload building to return plainMapcollections for user-set icons and external references.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/icon/icon.registry.ts | Builds BroadcastChannel payloads for RegisterIcon / UpdateIconReference using plain nested Maps. |
| src/components/icon/icon-state.broadcast.ts | Constructs sync-state collections / references payloads with plain nested Maps (no DefaultMap in messages). |
Member
|
Closing in favour of #2128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2126
DefaultMap instances contain a non-cloneable _factoryFn function property. When passed to BroadcastChannel.postMessage(), Safari throws DataCloneError since functions are not structured-cloneable (Chrome silently tolerates it).
Replace DefaultMap with plain Map objects in all broadcast payloads:
Description
Type of Change
Related Issues
Closes #
Testing
Checklist