Clickhouse array string find end has wrong regular expression for missing case#177
Open
loganma wants to merge 1 commit intoInfinidat:developfrom
Open
Clickhouse array string find end has wrong regular expression for missing case#177loganma wants to merge 1 commit intoInfinidat:developfrom
loganma wants to merge 1 commit intoInfinidat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old regular expression will missing the condition of the string has single quotes, which like ‘L'Oreal Paris' It will split into two words of "L" and "Oreal Paris'".
To judged as the end of a independent word in array, not only the single quotation mark needs to be judged, but also whether it is end with ',' or ']' can be determined as the end of word.