fix: allow empty secret values when setting secrets from .env file#96
Open
shashwat-dixit wants to merge 1 commit intoInfisical:mainfrom
Open
fix: allow empty secret values when setting secrets from .env file#96shashwat-dixit wants to merge 1 commit intoInfisical:mainfrom
shashwat-dixit wants to merge 1 commit intoInfisical:mainfrom
Conversation
Problem: - When running `infisical secrets set --file .env`, if any secret has an empty value, the CLI prints "Secret key 'X' has an empty value" and exits - The message is ambiguous - unclear if it's an error, warning, or info - The entire operation fails and no secrets are set - This is inconsistent with the Infisical UI which allows empty values Solution: - Remove the restriction that blocks empty secret values - Display an informational warning when empty values are detected - Continue processing and set all secrets from the file - Only block on empty keys (which are invalid), not empty values Changes: - packages/util/secrets.go: Replace PrintErrorMessageAndExit with warning message for empty values - packages/util/secrets.go: Update validation to only check for empty keys Testing: - Created .env file with empty value (KEY1=value1, KEY2=, KEY3=value3) - Verified all secrets are set successfully - Verified warning is displayed for empty value - Verified existing functionality still works for non-empty values Fixes Infisical#87
Contributor
Greptile SummaryThis PR fixes a usability issue where the CLI rejected empty secret values, even though the Infisical UI allows them. The changes convert the error into a warning, allowing the operation to continue. Changes:
Impact:
Confidence Score: 5/5
Important Files Changed
|
Contributor
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
Description
Problem:
infisical secrets set --file .env, if any secret has an empty value, the CLI prints "Secret key 'X' has an empty value" and exitsSolution:
Changes:
Type
Tests