-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(pki): add slack webhook to alerts #5346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pki): add slack webhook to alerts #5346
Conversation
Greptile OverviewGreptile SummaryThis PR adds Slack webhook integration to PKI alerts, allowing notifications to be sent to Slack channels alongside existing email and webhook channels. Key Changes:
Security Measures:
All previously reported issues have been addressed by the developer. Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 4 comments
backend/src/services/pki-alert-v2/pki-alert-v2-notification-fns.ts
Outdated
Show resolved
Hide resolved
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@greptile review |
…num, move webhook types to types file, increase timeout to 7s, and document channel retry behavior
…tion issues with long wehbook hostnames
…names, and block private IPs
…n-fns to pki-alert-v2-types for improved maintainability
…l-webhooks' into saif/pki-108-notification-channel-webhook-slack-integration # Conflicts: # backend/src/services/pki-alert-v2/pki-alert-v2-notification-fns.ts # backend/src/services/pki-alert-v2/pki-alert-v2-service.ts # frontend/src/views/PkiAlertsV2Page/components/CreatePkiAlertV2FormSteps.tsx
Context
This adds slack webhook to PKI alerts, earlier we only had emails and general webhooks.
Screenshots
Steps to verify the change
Add a slack webhook url to a new PKI alert
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).