-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Snyk] Fix for 4 vulnerabilities #5365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-FASTIFY-15182642 - https://snyk.io/vuln/SNYK-JS-FASTXMLPARSER-15155603 - https://snyk.io/vuln/SNYK-JS-FASTIFY-15182641 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile OverviewGreptile SummaryThis PR upgrades 5 npm dependencies to address 4 security vulnerabilities (2 high severity, 2 medium severity): Key Changes:
Security Impact:
Breaking Change Concerns:
Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 3 comments
| "bullmq": "^5.4.2", | ||
| "cassandra-driver": "^4.7.2", | ||
| "connect-redis": "^7.1.1", | ||
| "cron": "^3.1.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fastify 4→5 is a major version upgrade. Check that all fastify plugins are compatible with v5. The PR metadata indicates "isBreakingChange":true, so verify:
- All
@fastify/*plugins support v5 - Custom fastify plugins use v5-compatible APIs
- Test the application thoroughly before deploying
| "axios-ntlm": "^1.4.4", | ||
| "axios-retry": "^4.0.0", | ||
| "bcrypt": "^5.1.1", | ||
| "bcrypt": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bcrypt major version upgrade (5→6). Verify existing password hashes remain compatible with bcrypt v6's verification. Test authentication flows with existing user credentials before deploying to production.
| "acme-client": "^5.4.0", | ||
| "ajv": "^8.12.0", | ||
| "argon2": "^0.31.2", | ||
| "argon2": "^0.40.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argon2 major version upgrade (0.31→0.40). This library is used in SRP key generation (backend/src/lib/crypto/srp.ts) and blind indexing. Test that:
- Existing user SRP keys can still be verified
- Secret blind indexes work correctly
- The
raw: trueoutput format hasn't changed
Snyk has created this PR to fix 4 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
backend/package.jsonbackend/package-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-FASTIFY-15182642
SNYK-JS-FASTXMLPARSER-15155603
SNYK-JS-FASTIFY-15182641
SNYK-JS-TAR-15127355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Uncaught Exception
🦉 Directory Traversal