You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cleaning up function code and improving documentation
adding tests
adding a NEWS file
adding MIT license
There are currently some outstanding TODOs, so I've marked this as a draft:
implementing codecov and pkgdown on GitHub (I either need repo permissions or you'll need to set up the remaining bits)
write tests for reformat_data_sdtm_to_modeling(). This function is currently a big monolith. It would be nice to refactor into smaller functions for readability and testing
write code for reformat_data_modeling_to_nca() + tests. This function currently exists but has no code within the function
implementing codecov and pkgdown on GitHub (I either need repo permissions or you'll need to set up the remaining bits)
I added the "DS team" as admin member in this repo, you should be able to do anything now
write tests for reformat_data_sdtm_to_modeling(). This function is currently a big monolith. It would be nice to refactor into smaller functions for readability and testing
I would leave this for now, it's not currently being used in production. (can mark with a TODO, and maybe make a dummy tests file or so).
write code for reformat_data_modeling_to_nca() + tests. This function currently exists but has no code within the function
several misc TODOs (search TODO in the project)
Same, not used in production, can be left for now. Another alternative could be to remove these functions from the main branch, but add them to a dev branch.
@mccarthy-m-g FYI, changed name of the iterations argument in sample_covariates_mice(). replicates better matches what the output is, it's not really iterations like in fitting, it's actually creating longer output when not 1. Also in the mice package it's called number of replicates, not iterations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some package clean up, specifically:
There are currently some outstanding TODOs, so I've marked this as a draft:
reformat_data_sdtm_to_modeling(). This function is currently a big monolith. It would be nice to refactor into smaller functions for readability and testingreformat_data_modeling_to_nca()+ tests. This function currently exists but has no code within the function