Draft
Conversation
Member
thewtex
commented
Aug 13, 2024
thewtex
commented
- feat(image-sets-normalization): add new pipeline
- fix(image-sets-normalization): update codegened files for new pipeline
- feat(image-sets-normalization): Sort DICOMs
- feat(image-sets-normalization): read DICOM tags
- fix(gdcmDiscriminateVolume): Remove prints
- chore(test_image_sets_normalization): fix one series test
- refactor(image-sets-normalization): rename output to image-sets
- refactor(image-sets-normalization): revamp data structures
- fix(image-sets-normalization): fix sorting of files in series
- feat(image-sets-normalization): make tag keys english
- fix(image-sets-normalization): check more tags when grouping volumes
- feat(image-sets-normalization): array and number types for tag values
- chore(dicom): add mr test for image sets normalization
- WIP feat(image-sets-normalization): convert to UTF8 from character set
- WIP fix(image-sets-normalization): remove trailing space on tag values
- WIP fix(image-sets-normalization): fallback to tag hex key if private or empty
- WIP feat(image-sets-normalization): add group by options
13 tasks
thewtex
force-pushed
the
dicom-sort-rebase
branch
from
b5a3cf6 to
cb55c6f
Compare
Change CmakeLists to build image-sets-normalization for WASI. Fix wasi/__init__ to expose image_sets_normalization. Fix generated file import of image in test
Use GDCM discriminate volume example class.
Use DICOMTagReader to get all tags in files
refactor DicomFile to struct
Also, remove import of "itkGDCMImageIO.h" by extracting CharStringToUTF8Converter
thewtex
force-pushed
the
dicom-sort-rebase
branch
from
cb55c6f to
75f1c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.