-
-
Notifications
You must be signed in to change notification settings - Fork 717
ENH: Add link checker GHA workflow file #5377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ENH: Add link checker GHA workflow file #5377
Conversation
|
Not sure why it complains for the links to the commits in the release notes files. |
|
Many failures are due to HTTP code 429: Network error: Too Many Requests. Can we slow down request rate or something similar? |
Add link checker GHA workflow file: use the `lychee` action to check for broken links in Markdown, HTML, reStructuredText, and other files. Repository: https://github.com/lycheeverse/lychee-action Documentation: https://lychee.cli.rs/introduction/
ae36dc6 to
cb55e14
Compare
|
Looks like the limiting the rate of requests through caching does not work. Not sure if the cache has to be built first to have it working. Have gone through these but have not found how to modify the arguments to make throttling/request pace limiting work. Have seen other workflows accepting 429, e.g. but I guess that will effectively not check the links at issue. Also, checks will not work until this issue is solved: I do not know any other tool that does this job for rst files. This one only seems to work for md files: |
|
@jhlegarreta It seems like this effort has been abandoned due to difficulties. Perhaps this effort can be made into a manual script in the Utilities directory that is periodically run rather than addding it to the CI in a way that will slow down other efforts? I'm making a pass through issues trying reduce the number of stale, unlikely to proceed issues. |
|
@hjmjohnson thanks for the heads-up; going through challenging times on my end, so I am being unable to push ITK items. My sincere apologies. The approach you propose sounds reasonable. Feel free to close the PR. |
Add link checker GHA workflow file: use the
lycheeaction to check for broken links in Markdown, HTML, reStructuredText, and other files.Repository: https://github.com/lycheeverse/lychee-action
Documentation: https://lychee.cli.rs/introduction/
PR Checklist