BUG: code crashes when DICOM with 12 bits allocated is processed

[Purushoth24051999]

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

[github-actions]

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

[issakomi]

; at the end of the line 123.

Also (line 133, 134)

    assert (len == inOutBufferLength);
    gdcm_assert(inOutBufferLength == len);

becаme unreachable, can be deleted

[hjmjohnson]

@malaterre This issue may be resolved by removing line 133 in the upstream GDCM code. It looks like an assert persists in the code and causes the crash.

[issakomi]

@malaterre This issue may be resolved by removing line 133 in the upstream GDCM code. It looks like an assert persists in the code and causes the crash.

gdcm_assert(exception) won't be caught by ITK, even if it were, there would be a memory leak (copy is freed after this)

[dzenanz]

All the builds failed due to Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmRAWCodec.cxx:123:86: error: expected ';' after 'static_assert'

[malaterre]

Please see commit f57e45134ce6f0092687d0c4a69b5d7bee991dc5 in git/release branch. Let me know if this is acceptable solution.

Thanks all

[dzenanz]

@Purushoth24051999 please check malaterre/GDCM@f57e451. To easily do that, download and build this version of GDCM, then in ITK turn on ITK_USE_SYSTEM_GDCM. Then you should be able to pick GDCM_DIR.

[issakomi]

gdcm_assert (it throws an exception) is dead code (luckily)

[dzenanz]

This PR maybe/probably should have been made against upstream.

[Purushoth24051999]

This PR maybe/probably should have been made against upstream.

@dzenanz

I've tried malaterre/GDCM

by building with ITK_USE_SYSTEM_ITK as ON and linked External GDCM as you suggested it works fine for 12 bits allocated and NRRD file is generated without any issues

But I have few questions here,
According to DICOM standard Bits allocated can be either 1 or multiples of 8 else it is invalid but here instead of throwing error the handling made in malaterre/GDCM proceed to NRRD generation is it acceptable.

If so, I have modified this PR according to malaterre/GDCM to change contents of gdcmRAWCodec.cxx and gdcmBitmap.cxx files please review it.

[dzenanz]

It would be ideal if @malaterre tagged a new version. Meanwhile, I will open a PR to update bundled GDCM from 3.2.1 to 3.2.2.

[dzenanz]

PR #5568 opened.