Address namespace issue with GoogleTest libraries#5789
Open
blowekamp wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
Open
Address namespace issue with GoogleTest libraries#5789blowekamp wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
blowekamp wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
Conversation
Member
blowekamp
commented
Feb 10, 2026
blowekamp
commented
- Add depreciation warning for the removed GTest::GTest and GTest::Main targets.
- Correct the namespace to GTest in ITKTargets.
github-actions
bot
added
type:Infrastructure
blowekamp
force-pushed
the
gtest_alias_compatibility
branch
from
f54d8de to
9e28fc7
Compare
N-Dekker
reviewed
Feb 10, 2026
blowekamp
force-pushed
the
gtest_alias_compatibility
branch
from
9e28fc7 to
815e9bd
Compare
The ITK specific alias were removed, this change restores them with a deprecated warning.
Change to a function to avoid side effects during call. Use cmake_parse_arguments to parse additional NAMESPACE argument. Add detection of existing alias before setting.
Use added NAMESPACE option to itk_module_target to keep GTest namespace, fixing it being overridden to ITK.
blowekamp
force-pushed
the
gtest_alias_compatibility
branch
from
815e9bd to
df43a58
Compare
dzenanz
approved these changes
Feb 13, 2026
hjmjohnson
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.