Skip to content

Fix compilation issue with HDF5 and mingw.#5799

Draft
blowekamp wants to merge 2 commits intoInsightSoftwareConsortium:mainfrom
blowekamp:fix_hdf5_mingw
Draft

Fix compilation issue with HDF5 and mingw.#5799
blowekamp wants to merge 2 commits intoInsightSoftwareConsortium:mainfrom
blowekamp:fix_hdf5_mingw

Conversation

@blowekamp
Copy link
Member

PR includes

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

blowekamp and others added 2 commits February 13, 2026 20:43
See: HDFGroup/hdf5#5885

Explicitly disable detection of the problematic function.
This is change is pulled from commit
b09008ea0379e7b113ffdde4402860ba467ace13 upstream.

Define __STDC_WANT_IEC_60559_TYPES_EXT__ before including other headers (InsightSoftwareConsortium#5356)
Some standard headers might implicitly include `float.h`. If that happens
before `__STDC_WANT_IEC_60559_TYPES_EXT__` is defined, the macros that
are needed for the `_Float16` data type (like `FLT16_MAX`) might not be
defined.

That is happening with mingw-w64 headers since the following change: mingw-w64/mingw-w64@b40b6a0

Define `__STDC_WANT_IEC_60559_TYPES_EXT__` before including other headers
in `H5private.h` to make that scenario less likely.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants