Skip to content

ENH: Bump elastix to 5.3.0#363

Merged
N-Dekker merged 1 commit intoInsightSoftwareConsortium:mainfrom
N-Dekker:elastix-version-530
Feb 6, 2026
Merged

ENH: Bump elastix to 5.3.0#363
N-Dekker merged 1 commit intoInsightSoftwareConsortium:mainfrom
N-Dekker:elastix-version-530

Conversation

@N-Dekker
Copy link
Collaborator

Follow-up to pull request #344 commit 2821abb
"COMP: Use upstream elastix repository", July 2025.

@thewtex
Copy link
Member

thewtex commented Jan 26, 2026

@N-Dekker it looks like we get a slight difference in the registration, resulting in a small out-of-domain sampling at the lower left:

https://open.cdash.org/tests/2368766089

perhaps we increase the baseline comparison tolerance to allow more pixels? Or add a new baseline?

@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Jan 27, 2026

it looks like we get a slight difference in the registration, resulting in a small out-of-domain sampling at the lower left:

https://open.cdash.org/tests/2368766089

perhaps we increase the baseline comparison tolerance to allow more pixels? Or add a new baseline?

Thanks Matt. I see, you did already increase the tolerance before. Two times already:

So then, I wonder, what would cause these new differences? I wonder, would they be introduced by SuperElastix/elastix, somewhere between those revisions? SuperElastix/elastix@8c4f347...798346c

Is the registration result still fine anyway?


Update: Maybe it's pull request SuperElastix/elastix#1361 commit SuperElastix/elastix@6f031a5 (Reduce rounding errors "GridSpacingSchedule" GetDefaultParameterMap) So then indeed, we should have a new baseline! Can someone please 🙏 help me to get it there?

@N-Dekker N-Dekker force-pushed the elastix-version-530 branch from 8f50a54 to 05e9abd Compare January 28, 2026 21:45
@N-Dekker
Copy link
Collaborator Author

Update: this commit BUG: Replace default values of "GridSpacingSchedule" in test aims to solve the test failure without changing the baseline 🙏

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@thewtex
Copy link
Member

thewtex commented Jan 29, 2026

@N-Dekker great work!!

Looks like it will be green with a formatting fix.

@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Jan 29, 2026

Thanks for your encouranging comments @dzenanz, @thewtex I just moved the commit BUG: Replace default values of "GridSpacingSchedule" in test to its own pull request (#365), as I think it can already be applied before upgrading SuperElastix/elastix.

@N-Dekker N-Dekker force-pushed the elastix-version-530 branch 2 times, most recently from 12c2c99 to 2b11358 Compare January 29, 2026 22:38
@N-Dekker
Copy link
Collaborator Author

Build / py-dev / build-linux-py (11, 2014-x64) (pull_request) fails, saying:

Searching for wheels matching pattern dist/itk_*cp311*manylinux2014*x86_64.whl
ERROR    InvalidDistribution: Cannot find file (or expand pattern):             
         'dist/itk_*cp311*manylinux2014*x86_64.whl'                             

I'll give it another try!

@N-Dekker N-Dekker force-pushed the elastix-version-530 branch from 2b11358 to 1198b6e Compare February 1, 2026 22:00
Follow-up to pull request InsightSoftwareConsortium#344
commit 2821abb
"COMP: Use upstream elastix repository", July 2025.
@N-Dekker N-Dekker force-pushed the elastix-version-530 branch from 1198b6e to c5fd9ca Compare February 5, 2026 12:57
@N-Dekker N-Dekker changed the title WIP: Bump elastix to 5.3.0 ENH: Bump elastix to 5.3.0 Feb 5, 2026
@N-Dekker N-Dekker marked this pull request as ready for review February 5, 2026 16:20
@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Feb 5, 2026

When this is merged, shall we also make a new tag for ITKElastix? What about v0.24.0?

@thewtex
Copy link
Member

thewtex commented Feb 5, 2026

@N-Dekker 🎇

When this is merged, shall we also make a new tag for ITKElastix? What about v0.24.0?

Yes, we need to make sure to update the version first, here:

version = "0.23.0"

@N-Dekker N-Dekker merged commit 47ea2be into InsightSoftwareConsortium:main Feb 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants