-
Notifications
You must be signed in to change notification settings - Fork 27
STYLE: Minor rewording the explanation of image registration in example #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
N-Dekker
wants to merge
1
commit into
InsightSoftwareConsortium:main
Choose a base branch
from
N-Dekker:Adjust-image-registration-explanation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback, Matt. First of all, this is not a show-stopper to me, of course. If you don't want it to be merged, please press "Request changes", or even "Close pull request" without merging.
Anyway, my main aim is to get rid of "in the presence of noise". I don't think "the presence of noise" is essential to image registration. Image registration is often used to register baseline and follow-up, or to register two different modalities. But we can also register artificially generated images. Even if the images would be entirely free of noise, it would still be valid to call it "image registration".
The example itself does not elaborate any further on the noise that is supposed to be present. So I don't think it's essential to the example either.
We have another definition of image registration at https://github.com/SuperElastix/elastix/blob/9f87f8943ac5c90bf5fffa1b5ac1566a607ad020/README.md#L17
The proposed rewording would bring the text from the example more in sync with this definition from SuperElastix/elastix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-Dekker yes, I agree that the methods can be used for artificially generated images. I think it is helpful to emphasize that the quest when working natural images, which I think is the most common end use case for elastix. We are
where the optimization and similarity metric has to distinguish what content is expected to correspond and what content is not expected to correspond (noise).
I do not have strong attachments myself; I am sharing my preference and how I think "noise" should be understood and its significance in this context.