Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the end-to-end (ETE) test infrastructure for the LMDeploy project. The changes focus on:
- Consolidating test configuration into structured dictionaries (
run_config) - Standardizing CLI parameter generation and service startup functions
- Removing deprecated helper functions and simplifying test files
- Improving environment variable management and log file naming
Changes:
- Refactored test utilities to use configuration dictionaries instead of individual parameters
- Consolidated CLI parameter generation into centralized functions
- Simplified test case files by removing boilerplate code
- Updated configuration file structure for better organization
Reviewed changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| autotest/utils/run_restful_chat.py | Major refactoring: new start_openai_service, consolidated parameter handling, replaced eval() with json.loads() |
| autotest/utils/config_utils.py | Complete rewrite: new functions for config generation, CLI param building, case naming |
| autotest/utils/run_client_chat.py | Simplified to use new config structure and helper functions |
| autotest/utils/pipeline_chat.py | Refactored to use run_config pattern, improved command execution |
| autotest/tools/restful/*.py | Simplified test files using new helper functions and config patterns |
| autotest/tools/pipeline/*.py | Updated to use new config structure and consolidated functions |
| autotest/tools/common_case_config.py | New file containing test case configurations |
Comments suppressed due to low confidence (1)
autotest/evaluate/test_api_evaluate.py:71
- Keyword argument 'model_param' is not a supported parameter name of ApiServerPerTest.init.
api_server = ApiServerPerTest(proxy_manager=manager, model_path=model_path, model_param=model_param)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lvhan028
reviewed
Jan 27, 2026
| help='Name or path of the model. If not set, the default model will ' | ||
| 'request /v1/models for conf.', | ||
| ) | ||
| parser.add_argument( |
Collaborator
There was a problem hiding this comment.
What's the motivation to change profile_restful_api.py?
lvhan028
reviewed
Jan 27, 2026
lvhan028
reviewed
Jan 27, 2026
lvhan028
reviewed
Jan 27, 2026
lvhan028
reviewed
Jan 27, 2026
lvhan028
reviewed
Jan 27, 2026
lvhan028
reviewed
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.