Fix for config entry rename bug.#260
Open
mattrcampbell wants to merge 1 commit intoInternet2:GROUPER_5_BRANCHfrom
Open
Fix for config entry rename bug.#260mattrcampbell wants to merge 1 commit intoInternet2:GROUPER_5_BRANCHfrom
mattrcampbell wants to merge 1 commit intoInternet2:GROUPER_5_BRANCHfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell this code was not going to work with PAC4J 6. The setter for these two configuration entries could not be found because the hashmap lookup was trying to find something that was in the VALUE, not the key. I have testing this fix in our install, it works for us!
Additionally line 79 worked, but would cause issues if any entries were ever added to the hashmap that had differing lengths between key/value.