Possible fix for tmpnam.

[thyrgle]

According to here you should not use tmpnam. I am not familiar with Socket programming, so I am not sure how to test. I believe I have fixed it by replacing it with mkstemp, but I'm not completely sure. Nevertheless, this is an issue that should be addressed.

[stevedekorte]

Thanks Chris. Do we know if this works on all platforms?

[thyrgle]

I am not certain.

[acook]

Looks like there's a minor whitespace issue here.

[thyrgle]

Funny, the whitespace doesn't show up incorrectly on my computer. Probably some issue with my vim configuration.

[joedf]

mkstemp() seems to be part of the GNU C Library.

[acook]

@stevedekorte It looks like it's supported at least on FreeBSD, Linux, OSX, and Solaris.

[stevedekorte]

Can anyone test it on Windows?

[acook]

Looks like it's deprecated on Windows.

• There's a Visual Studio 2015 reference for _mkstemp (note the underscore) but seems pretty identical otherwise: https://msdn.microsoft.com/en-us/library/34wc6k1f.aspx
• Here's a usage example of the _msktemp function on Windows from the "Unix to Windows Porting Dictionary": http://66.165.136.43/dictionary/mkstemp-entry.php
• Here's a (LGPL) C implementation of mkstemp which could be included instead: https://github.com/Kazade/Tasks/blob/master/u1dbrepo/src/mkstemp_compat.c

[stevedekorte]

If someone would like to mod the patch to work on windows, I can accept it.

[ghost]

Hope you don't mind me jumping in but:

• the code with tmpnam is only used when __APPLE__ is defined.
• The VS2015 reference for _mkstemp that @acook referenced is for _mktemp which is different.
• As far as I can see mkstemp needs to be called with a template argument which is overwritten, not NULL (I can't test this at the moment)

So I think you just need a solution for OS X, probably using mktemp. Also popen might be an option.

[ghost]

Quick thought on using popen - good because it avoids all the temporary file issues.

#include <stdio.h>

int main(void) {
  static char answer[1024];
  FILE* fp = popen("dig|grep SERVER:", "r");
  if (fp) {
    fread(answer, 1, 1024, fp);
    /* Do something with 'answer' ... */
    puts(answer);
    pclose(fp);
  } else {
    /* Error */
  }
}

Tested on Linux, not yet on OS X.