Uploaded script for Uniprot to ncbi function addresses issue #109#139
Open
SunSummoner wants to merge 5 commits intoJRaviLab:mainfrom
Open
Uploaded script for Uniprot to ncbi function addresses issue #109#139SunSummoner wants to merge 5 commits intoJRaviLab:mainfrom
SunSummoner wants to merge 5 commits intoJRaviLab:mainfrom
Conversation
3 tasks
Added functions to map NCBI RefSeq Protein IDs to UniProt Accessions and NCBI Protein Accessions to IPG IDs.
the-mayer
reviewed
Oct 29, 2025
the-mayer
reviewed
Oct 29, 2025
the-mayer
reviewed
Oct 29, 2025
the-mayer
requested changes
Oct 29, 2025
Collaborator
the-mayer
left a comment
There was a problem hiding this comment.
Great start! Everything works as described!
A couple of suggestions before approving/merging:
- Let's avoid using
library()andrequireNamespace()in user facing functions. Instead, we should rely on roxygen import tags to handle package dependencies. - MolEvolvR already has quite a few dependencies, it might be worth refactoring
acc2ipg()to usehttr2. That would let us drophttrand simplify the dependencies for the package
Thanks for putting this together and apologies for the delay in getting the review back to you!
Collaborator
Author
Thanks for the suggestions. I will keep them in mind miving forward. |
jananiravi
reviewed
Dec 1, 2025
Renamed functions and updated documentation for consistency. Used @importFrom for sourcing and changed function and variable names to match the convention. Removed other inconsistencies
Removed commented-out example usage from documentation.
jananiravi
approved these changes
Jan 23, 2026
Member
|
have these been tested on example accessions -- assuming local checks are now working? If so, I'd be happy to merge this right away. thank you, @SunSummoner! |
Collaborator
Author
|
@jananiravi the example accessions are working! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.