Conversation
Signed-off-by: Awa Synthia <ndahili14@gmail.com>
Signed-off-by: Awa Synthia <ndahili14@gmail.com>
R/reverse_operons.R
Outdated
| #' # Example genomic context data frame | ||
| #' prot <- data.frame(GenContext = c("A>B", "C<D", "E=F*G", "H>I")) | ||
| #' reversed_prot <- reverseOperonSeq(prot) | ||
| #' print(reversed_prot) |
There was a problem hiding this comment.
@awasyn , can you double check this example code?
There was a problem hiding this comment.
Thanks. I will run example again.
There was a problem hiding this comment.
I'm still seeing an R-CMD check error when running this example:
❯ checking examples ... [14s/15s] ERROR
Running examples in ‘MolEvolvR-Ex.R’ failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: reverseOperonSeq
> ### Title: reverseOperon: Reverse the Direction of Operons in Genomic
> ### ContextSeq
> ### Aliases: reverseOperonSeq
>
> ### ** Examples
>
> # Example genomic context data frame
> prot <- data.frame(GenContext = c("A>B", "C<D", "E=F*G", "H>I"))
> reversed_prot <- reverseOperonSeq(prot)
Error in ge[[x]] : subscript out of bounds
Calls: reverseOperonSeq -> lapply -> FUN -> straightenOperonSeq
Execution halted
Using the example data defined in prot the error occurs during the lapply operation @line 137 as ge has length 0 due to the previous subset operation.
There was a problem hiding this comment.
Excellent work adding to the package documentation! I've made a few requests for changes (picked some representative examples, but changes should be made throughout).
Overall this looks great and is another step towards enabling the CI in #34
…al issues Signed-off-by: Awa Synthia <ndahili14@gmail.com>
|
Thanks @the-mayer , sorry for the delay. I was finishing my final application for the internship. |
Document parameters
What kind of change(s) are included?
[R-pkg] Status check #2
🐞[BUG] fix check bugs #33
Bug fix (fixes check).(
devtools::document()) Should be cleaned when merged with: Add parameter definitions to summarize.R #41Enhancement (documentation).
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.
@the-mayer