Skip to content

Exit if no features#4

Merged
JTFouquier merged 1 commit intoJTFouquier:mainfrom
mikemull:issue3-no-features
Feb 17, 2025
Merged

Exit if no features#4
JTFouquier merged 1 commit intoJTFouquier:mainfrom
mikemull:issue3-no-features

Conversation

@mikemull
Copy link
Contributor

Hi @JTFouquier. I started this pull request to address Jaime's problem (see Issue #3 ). This only addresses one particular case though. I don't know if you want to cover other possible failure cases.

Copy link
Owner

@JTFouquier JTFouquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, thanks!

The bigger picture that I didn't address well is for cases when one model works completely (like Original or Pairwise, which is common), but when the other models like First or Previous fail for the RF/MERF step or BorutaSHAP step. The report should still be created because one model worked and there should be no results in the other sections. When RF fails at <5% percent variation explained, I made empty PDFs to "fail elegantly"... this can potentially be reused for the BorutaSHAP step. Maybe I just didn't think of that case.

Cases could be as follows as far as "selecting features" for each model (Original, First, Previous or Pairwise):

RF/MERF pass
BorutaSHAP pass
This builds complete pdf reports; satisfies pdf file for Snakefile rule all

RF/MERF pass
BorutaSHAP fail
Currently causing issues especially when some models works but not others; report won't be created here.

RF/MERF fail
BorutaSHAP fail
Fails at RF/MERF so an empty pdf is created to satisfy rule all, so BorutaSHAP was irrelevant here.

Now that I wrote this out, I'll give it a go. :)

@JTFouquier JTFouquier merged commit 8c4815f into JTFouquier:main Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants