Don't pin memory if device not set to use an accelerator.#1419
Open
brownsloth wants to merge 1 commit intoJaidedAI:masterfrom
Open
Don't pin memory if device not set to use an accelerator.#1419brownsloth wants to merge 1 commit intoJaidedAI:masterfrom
brownsloth wants to merge 1 commit intoJaidedAI:masterfrom
Conversation
|
I just rebuilt this modification and tested it on AWS Lambda with Python 3.13, and checked that it works without any errors. Before
It had pin_memory warning even I setted EasyOCR with CPU only. It seems be occurred in pytorch.util.data.dataLoader option. But As I know, 'pin_memory' option works for sending GPU(cuda) synchronously. So when using CPU only envireonment, It makes warning. Afterthere no warning with 'pin_memory' Tested on:
|
|
I don't have the expertise to know the real consequences of this 3-line change, but it looks reasonable to me. If testing this locally would help the maintainers to merge this PR, I'd be happy to give it a try. |
|
It's useful! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1414