Support distinct select on string enums #4119
Merged
+61
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for Distinct on nullable enums serialized as strings (System.Text.Json) and include Weasel.Core using. Refactor NewScalarSelectClause to centralize scalar reading into ReadScalar/ReadScalarAsync, simplify null checks, and add handling for enums stored as strings (Enum.Parse) or as integers, for both sync and async paths. Also remove the #nullable enable directive at the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for Distinct on nullable enums serialized as strings. Refactor NewScalarSelectClause to centralize scalar reading into ReadScalar/ReadScalarAsync, simplify null checks, and add handling for enums stored as strings (Enum.Parse) or as integers, for both sync and async paths. Also remove the #nullable enable directive at the top of the file.