Skip to content

Fix already bound assert for extensions #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slavam2605 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix already bound assert for extensions #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rd-kt/rd-framework/src/main/kotlin/com/jetbrains/rd/framework/base/RdExtBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ abstract class RdExtBase : RdReactiveBase() {

//todo make it smarter
for ((name, child) in bindableChildren) {
if (child is RdExtBase && child.parent == this) {
// Extensions can be created from extension listener above, in submitExtCreated,
// and they will be already bound at this point, so we should skip them
continue
}
if (child is RdPropertyBase<*> && child.defaultValueChanged) {
child.localChange {
child.bind(lifetime, this, name)
Expand Down