Remove public acronym submission functionality#134
Open
kathirpsmy wants to merge 1 commit intoJonathanGarro:mainfrom
Open
Remove public acronym submission functionality#134kathirpsmy wants to merge 1 commit intoJonathanGarro:mainfrom
kathirpsmy wants to merge 1 commit intoJonathanGarro:mainfrom
Conversation
- Prevent non-registered users from submitting acronyms. - Only registered members can submit acronym requests now. - Removed public access to acronym submission functionality.
Owner
|
Thanks @kathirpsmy ! @danbjoseph, just a reminder that the documentation will need to be updated. As this public editing feature was originally designed as a way to replace the functionality of the BRC's acronym tool (and which accepted public submissions), this team will want to proactively message why the public feature is being removed. |
|
Please reconsider the risk/benefit impact of not implementing this. I'm not fully convinced we'd want to limit the possibility of adding new entries to only logged-in users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131