Fix #2141: Enable write-related attributes on positional record constructor parameters#2351
Open
SteveGuoh wants to merge 1 commit intoJoshClose:masterfrom
Open
Fix #2141: Enable write-related attributes on positional record constructor parameters#2351SteveGuoh wants to merge 1 commit intoJoshClose:masterfrom
SteveGuoh wants to merge 1 commit intoJoshClose:masterfrom
Conversation
…ord constructor parameters and field-style records (JoshClose#2141)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Fixes #2141
✅ Problem
This PR resolves the issue where attributes like
[Format],[Constant], and[Default]have no effect when applied to parameters in positional record constructors, particularly duringWriteRecords()operations.🔍 Original Issue Example (from #2141)
Given the following record:
And the following code:
❌ Actual Output (Before Fix)
✅ Expected Output (After Fix)
🛠️ Changes
FormatAttribute,ConstantAttribute,DefaultAttribute, etc.) on positional record constructor parameters.✅ Tests
📦 Impact
recordtypes, reducing the need for verbose ClassMap definitions in many scenarios.