Skip to content

CatBoostRegressor.subsample should be Float64#36

Open
liuyxpp wants to merge 1 commit intoJuliaAI:mainfrom
liuyxpp:patch-1
Open

CatBoostRegressor.subsample should be Float64#36
liuyxpp wants to merge 1 commit intoJuliaAI:mainfrom
liuyxpp:patch-1

Conversation

@liuyxpp
Copy link

@liuyxpp liuyxpp commented Mar 25, 2024

According to CatBoost doc, it should be a floating number in the range (0, 1].

The proof is if you set an integer larger than 1 to subsample and train, you will get the error:

Python: CatBoostError: /src/catboost/catboost/private/libs/options/bootstrap_options.cpp:5: Subsample should be in (0,1]

@ericphanson
Copy link
Collaborator

Can you add a test that uses the functionality? To ensure we don’t regress

@ablaom
Copy link
Member

ablaom commented Jun 18, 2024

@liuyxpp any chance of adding that test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants